Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close the menu when the query becomes empty #6

Merged
merged 2 commits into from
Feb 3, 2017
Merged

Conversation

tvararu
Copy link
Contributor

@tvararu tvararu commented Feb 3, 2017

This was introduced in #5.

Also clean up some unnecessary lines from a few tests.

@@ -96,6 +96,8 @@ export default class Typeahead extends Component {
options
})
})
} else if (queryEmpty) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 💪

Copy link

@dankmitchell dankmitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@tvararu tvararu merged commit 4ef4b19 into master Feb 3, 2017
@tvararu tvararu deleted the fix-empty-query branch February 3, 2017 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants