Add Node LTS dev version/update CONTRIBUTING.md #609
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgarner
force-pushed
the
add-dev-versions-for-python-and-node
branch
from
fc01781
to
dce97be
Compare
Also update CONTRIBUTING.md to match. For contribution, add versions we know to work together. @wdio/sync brings fibers, which needs compilation. That compilation fails for some combinations of Node and Python: ``` ValueError: invalid mode: 'rU' while trying to load binding.gyp ``` or ``` npm ERR! ../src/fibers.cc:27:65: error: no member named 'kFinalizer' in 'v8::WeakCallbackType' npm ERR! handle.SetWeak(val, WeakCallbackShim<F, P>, WeakCallbackType::kFinalizer); npm ERR! ~~~~~~~~~~~~~~~~~~^ ``` Fixes alphagov#608.
rgarner
force-pushed
the
add-dev-versions-for-python-and-node
branch
from
dce97be
to
c7995df
Compare
rgarner
changed the title
|
@rgarner Morning 👋 Do you mind giving this PR branch a try? Turns out WebdriverIO "sync" mode is deprecated (via Looks like it's this that was causing the Python |
|
@colinrotherham Great! I can yes. Should be able to get to it this afternoon? |
Perfect, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update
CONTRIBUTING.mdto match.All of the below fixed by #612, which no longer uses the deprecated sync method provided by
@wdio/syncFor contribution, add versions we know to work together.
@wdio/syncbringsfibers, which needs compilation. That compilation fails for some combinations of Node and Python:or
Fixes #608.