Add className attribute to status component
#620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The status component is currently hidden from view using inline CSS, however in an implementation that applies aggressive CSP controls these styles cannot be applied, and since the status element has minimal other identifying attributes, it is difficult to apply corresponding styles in .css files. Apply a class attribute to the status component - defaulting to `autocomplete__status` so that it can be reliably targeted by CSS selectors.
36degrees
approved these changes
Jan 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally posted by @lennym in #453
Rebases and re-builds dist as I didn't manage to push to the contributor's branch 馃様 .