Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to latest version of govuk-lint when it is released (v3.0.0) #85

Closed
floehopper opened this issue Jul 25, 2017 · 2 comments
Closed

Upgrade to latest version of govuk-lint when it is released (v3.0.0) #85

floehopper opened this issue Jul 25, 2017 · 2 comments
Assignees
@floehopper
Labels
upgrade

Comments

@floehopper
Copy link
Contributor

In this pull request I was forced to disable a Rubocop rule for one line, because it was overly strict. I've opened this pull request on govuk-lint to upgrade the versions of Rubocop it allows. Once that PR is merged, it would be good to upgrade govuk-lint in this app and remove the disabling of that Rucocop rule assuming it ends up getting merged. Even if it doesn't it would be good to upgrade.
@floehopper
Copy link
Contributor Author

I've just merged alphagov/govuk-lint#77. Once the gem is released, I'll look at upgrading govuk-lint in this project.

@floehopper floehopper self-assigned this Jul 26, 2017
@floehopper
Copy link
Contributor Author

This pull request which upgrades to govuk-lint v3.1.0 has been merged. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@floehopper floehopper

Labels
upgrade
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@floehopper