This repository has been archived by the owner on Jan 6, 2020. It is now read-only.
Allow v0.49.x of rubocop and bump version to v3.0.0 #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes are mostly bug fixes or new features, so I don't think there's too much risk in relaxing the constraint to allow the latest version (v0.49.1) of `rubocop`. My specific motivation is the relaxation of the "Style/VariableNumber" rule in this commit [1] which I believe was first released in v0.44.0. [1]: rubocop/rubocop@833aad6
This was in response to the following error message which occurred when
running `govuk-lint-ruby` in a project using rubocop v0.49.1:
obsolete parameter IndentWhenRelativeTo (for Layout/CaseIndentation)
found in $PROJECT_ROOT/configs/rubocop/gds-ruby-styleguide.yml
`IndentWhenRelativeTo` has been renamed to `EnforcedStyle`
This was in response to the following error message which occurred when
running `govuk-lint-ruby` in a project using rubocop v0.49.1:
Error: The `Style/MethodCallParentheses` cop has been renamed to
`Style/MethodCallWithoutArgsParentheses`. (obsolete configuration
found in $PROJECT_ROOT/configs/rubocop/gds-ruby-styleguide.yml,
please update it)
This was in response to the following warning which occurred when
running `govuk-lint-ruby` in a project using rubocop v0.49.1:
Warning: unrecognized parameter
Style/TrailingCommaInLiteral:SupportedStyles found in
$PROJECT_ROOT/configs/rubocop/gds-ruby-styleguide.yml
floehopper
changed the title
boffbowsh
approved these changes
Jul 26, 2017
|
@boffbowsh: Thanks for reviewing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rubocopfrom "~> 0.43.0" to "~> 0.49.0". The latest version ofrubocopis v0.49.1.configs/rubocop/gds-ruby-styleguide.yml.CHANGELOG.mdThe changes in
rubocopare mostly bug fixes or new features, so I don't think there's too much risk in relaxing the constraint to allow the latest version. And in any case each project is in control of which version ofgovuk-lintbeing used and thence the versionrubocop.My specific motivation is the relaxation of the "Style/VariableNumber" rule in this commit which I believe was first released in v0.44.0. The strictness of this rule in v0.43.0 is causing me a problem in
asset-managerapp where I want to use a local variable namedaws_s3_bucket_name.