[DO NOT MERGE] Serve assets from S3 if they exist #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisroos
changed the title
chrisroos
changed the title
2 tasks
This is a temporary change that will allow us to test redirecting to and serving assets from S3 on integration. This commit causes some tests to fail but we're not worrying about that as we're not expecting this commit to end up in master. We've tested the change locally and are happy that it results in a redirect to assets uploaded to S3. Assets not on S3 continue to be served directly from the filesystem.
chrisroos
force-pushed
the
redirect-to-s3-if-asset-has-been-uploaded
branch
from
ecf0e96
to
d1b95c5
Compare
|
I'm going to close this because I don't think we need it any more and in any case I'll leave the remote branch in place in case we do need it again. |
|
Thanks @floehopper. I'm going to delete the branch as we can always recreate the changes based on the diff in this PR if we need to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE. We're not intending for this branch to be merged to master. We're going to use it to test the behaviour of redirecting to S3 in integration.
This is a temporary change that will allow us to test redirecting to and
serving assets from S3 on integration.
This commit causes some tests to fail but we're not worrying about that
as we're not expecting this commit to end up in master.
We've tested the change locally and are happy that it results in a
redirect to assets uploaded to S3. Assets not on S3 continue to be
served directly from the filesystem.