Upgrade Ruby 2.2.3 -> 2.3.1 #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floehopper
approved these changes
Jul 25, 2017
There was a problem hiding this comment.
- No failing specs or warnings when running specs.
- Specs & app run OK on developer VM, e.g. the required Ruby version is available via
rbenv. - No errors or new warnings in log file when running
cURLcommands against app running in developer VM in conjunction with its worker process which also works fine.
I'm happy for this to be merged, but I think it would be good to get it deployed a.s.a.p. (i.e. with as few other changes at the same time) and do some manual checks that the app is still working immediately after the deployment.
I'd also like to get various gems upgraded as soon as possible to (hopefully) reduce the chance of any nasty surprises.
|
@floehopper thank you for checking that in such detail, much appreciated. I've got a PR incoming for a mongoid upgrade, agreed we should press on with upgrading others.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #75
The tests continue to pass with this version of Ruby. I don't think it requires any other changes.