Fix various PEP8 warnings

alphagov · Feb 20, 2014 · a4c855e · robyoung · Mar 12, 2014 · a4c855e
1 parent c13ad77
commit a4c855e
Show file tree

Hide file tree

Showing 6 changed files with 49 additions and 51 deletions.
diff --git a/backdrop/admin/app.py b/backdrop/admin/app.py
@@ -8,8 +8,6 @@
 from ..core import cache_control, log_handler, database
 from ..core.bucket import Bucket
 from ..core.errors import ParseError, ValidationError
-from ..core.log_handler \
-    import create_request_logger, create_response_logger
 from ..core.repository \
     import BucketConfigRepository, UserConfigRepository
 from ..core.flaskutils import BucketConverter

diff --git a/backdrop/read/api.py b/backdrop/read/api.py
@@ -3,10 +3,8 @@
 from os import getenv
 from bson import ObjectId
 
-from flask import Flask, jsonify, request, redirect
+from flask import Flask, jsonify, request
 from flask_featureflags import FeatureFlag
-from backdrop.core.log_handler \
-    import create_request_logger, create_response_logger
 from backdrop.read.query import Query
 
 from .validation import validate_request_args

diff --git a/backdrop/read/config/development.py b/backdrop/read/config/development.py
@@ -3,44 +3,44 @@
 MONGO_PORT = 27017
 LOG_LEVEL = "DEBUG"
 RAW_QUERIES_ALLOWED = {
-  "government_annotations": True,
-  "govuk_realtime": True,
-  "licence_finder_monitoring": True,
-  "licensing": False,
-  "licensing_journey": True,
-  "licensing_monitoring": True,
-  "licensing_realtime": True,
-  "lpa_volumes": True,
-  "lpa_monitoring": True,
-  # electronic vehicle licensing
-  "electronic_vehicle_licensing_monitoring": True,
-  "evl_customer_satisfaction": True,
-  "evl_volumetrics": True,
-  "sorn_monitoring": True,
-  "sorn_realtime": True,
-  "tax_disc_monitoring": True,
-  "tax_disc_realtime": True,
-  # fco
-  "deposit_foreign_marriage_journey": True,
-  "deposit_foreign_marriage_monitoring": True,
-  "deposit_foreign_marriage_realtime": True,
-  "pay_foreign_marriage_certificates_journey": True,
-  "pay_foreign_marriage_certificates_monitoring": True,
-  "pay_foreign_marriage_certificates_realtime": True,
-  "pay_legalisation_drop_off_journey": True,
-  "pay_legalisation_drop_off_monitoring": True,
-  "pay_legalisation_drop_off_realtime": True,
-  "pay_legalisation_post_journey": True,
-  "pay_legalisation_post_monitoring": True,
-  "pay_legalisation_post_realtime": True,
-  "pay_register_birth_abroad_journey": True,
-  "pay_register_birth_abroad_monitoring": True,
-  "pay_register_birth_abroad_realtime": True,
-  "pay_register_death_abroad_journey": True,
-  "pay_register_death_abroad_monitoring": True,
-  "pay_register_death_abroad_realtime": True,
-  # HMRC preview
-  "hmrc_preview": True,
-  # LPA / Lasting Power of Attorney
-  "lpa_journey": True,
+    "government_annotations": True,
+    "govuk_realtime": True,
+    "licence_finder_monitoring": True,
+    "licensing": False,
+    "licensing_journey": True,
+    "licensing_monitoring": True,
+    "licensing_realtime": True,
+    "lpa_volumes": True,
+    "lpa_monitoring": True,
+    # electronic vehicle licensing
+    "electronic_vehicle_licensing_monitoring": True,
+    "evl_customer_satisfaction": True,
+    "evl_volumetrics": True,
+    "sorn_monitoring": True,
+    "sorn_realtime": True,
+    "tax_disc_monitoring": True,
+    "tax_disc_realtime": True,
+    # fco
+    "deposit_foreign_marriage_journey": True,
+    "deposit_foreign_marriage_monitoring": True,
+    "deposit_foreign_marriage_realtime": True,
+    "pay_foreign_marriage_certificates_journey": True,
+    "pay_foreign_marriage_certificates_monitoring": True,
+    "pay_foreign_marriage_certificates_realtime": True,
+    "pay_legalisation_drop_off_journey": True,
+    "pay_legalisation_drop_off_monitoring": True,
+    "pay_legalisation_drop_off_realtime": True,
+    "pay_legalisation_post_journey": True,
+    "pay_legalisation_post_monitoring": True,
+    "pay_legalisation_post_realtime": True,
+    "pay_register_birth_abroad_journey": True,
+    "pay_register_birth_abroad_monitoring": True,
+    "pay_register_birth_abroad_realtime": True,
+    "pay_register_death_abroad_journey": True,
+    "pay_register_death_abroad_monitoring": True,
+    "pay_register_death_abroad_realtime": True,
+    # HMRC preview
+    "hmrc_preview": True,
+    # LPA / Lasting Power of Attorney
+    "lpa_journey": True,
 }
diff --git a/tests/core/integration/test_repository.py b/tests/core/integration/test_repository.py
@@ -55,7 +55,8 @@ def test_retrieves_config_for_service_and_data_type(self):
         self.repository.save(BucketConfig("b2", data_group="my_service", data_type="not_my_type"))
         self.repository.save(BucketConfig("b3", data_group="not_my_service", data_type="my_type"))
 
-        config = self.repository.get_bucket_for_query(data_group="my_service", data_type="my_type")
+        config = self.repository.get_bucket_for_query(
+            data_group="my_service", data_type="my_type")
 
         assert_that(config.name, is_("b1"))
 

diff --git a/tests/core/test_repository.py b/tests/core/test_repository.py
@@ -1,10 +1,11 @@
 import unittest
-from collections import namedtuple
+
 from backdrop.core.bucket import BucketConfig
-from backdrop.core.repository import BucketConfigRepository, UserConfigRepository
+from backdrop.core.repository import (BucketConfigRepository,
+                                      UserConfigRepository)
 from hamcrest import assert_that, equal_to, is_, has_entries, match_equality
 from mock import Mock
-from nose.tools import *
+from nose.tools import assert_raises
 from backdrop.core.user import UserConfig
 
 

diff --git a/tests/read/test_read_api_service_data_endpoint.py b/tests/read/test_read_api_service_data_endpoint.py
@@ -1,8 +1,8 @@
 import unittest
 import urllib
 import datetime
-from hamcrest import *
-from mock import patch, Mock
+from hamcrest import assert_that, is_
+from mock import patch
 import pytz
 from backdrop.core.timeseries import WEEK
 from backdrop.read import api