Exclude hour from midnight boundary check

backdrop/core/timeseries.py

@@ -88,7 +88,7 @@ def valid_start_at(self, timestamp):
 DAY = Day()
 WEEK = Week()
 MONTH = Month()
-PERIODS = [DAY, WEEK, MONTH]
+PERIODS = [HOUR, DAY, WEEK, MONTH]
 
 
 def parse_period(period_name):

backdrop/read/validation.py

@@ -228,7 +228,7 @@ def _is_valid_date_query(self, request_args):
 class MidnightValidator(Validator):
     def validate(self, request_args, context):
         timestamp = request_args.get(context['param_name'])
-        if _is_valid_date(timestamp):
+        if _is_valid_date(timestamp) and request_args.get('period') != 'hour':
             dt = parser.parse(timestamp).astimezone(pytz.UTC)
             if dt.time() != time(0):
                 self.add_error('%s must be midnight' % context['param_name'])

tests/read/test_validation.py

@@ -268,7 +268,7 @@ def test_queries_with_period_values_must_be_certain_values(self):
         })
 
         assert_that(validation_result, is_invalid_with_message(
-            "'period' must be one of ['day', 'week', 'month']"))
+            "'period' must be one of ['hour', 'day', 'week', 'month']"))
 
     def test_queries_without_a_colon_in_sort_by_are_disallowed(self):
         validation_result = validate_request_args({
@@ -349,6 +349,14 @@ def test_queries_with_dates_at_middle_of_day_are_not_allowed(self):
             "start_at must be midnight"
         ))
 
+    def test_queries_for_hour_period_with_dates_at_middle_of_day_are_allowed(self):
+        validation_result = validate_request_args({
+            'period': 'hour',
+            'start_at': '2000-02-02T12:00:00+00:00',
+            'end_at': '2000-02-19T13:00:00+00:00'
+        }, False)
+        assert_that(validation_result, is_valid())
+
 
 class TestValidationHelpers(TestCase):
     def test_timestamp_is_valid_method(self):