Merge pull request #338 from alphagov/remove-create-route

Remove create data set route

backdrop/write/api.py

@@ -175,33 +175,6 @@ def post_to_data_set(data_set_name):
         abort(400, repr(e))
 
 
-@app.route('/data-sets/<data_set_name>', methods=['POST'])
-@cache_control.nocache
-@statsd.timer('write.route.create_data_set')
-def create_collection_for_data_set(data_set_name):
-    if not _allow_create_collection(request.headers.get('Authorization')):
-        abort(401,
-              'Unauthorized: invalid or '
-              'no token given for "{}".'.format(data_set_name))
-
-    if storage.data_set_exists(data_set_name):
-        abort(400, 'Collection exists with name "{}".'.format(data_set_name))
-
-    try:
-        data = json.loads(request.data)
-    except ValueError as e:
-        abort(400, repr(e))
-    else:
-        capped_size = data.get('capped_size', None)
-
-    if capped_size is None or not isinstance(capped_size, int):
-        abort(400, 'You must specify an int capped_size of 0 or more')
-
-    storage.create_data_set(data_set_name, capped_size)
-
-    return jsonify(status='ok', message='Created "{}"'.format(data_set_name))
-
-
 @app.route('/data-sets/<data_set_name>', methods=['DELETE'])
 @cache_control.nocache
 @statsd.timer('write.route.delete_data_set')

features/write_api/delete_data_set.feature

@@ -4,11 +4,14 @@ Feature: delete_data_set
     @delete_things
     Scenario: deleting a data-set
         Given I have a data_set named "some-dataset" with settings
-            | key        | value       |
-          and I have JSON data '{"capped_size": 4096}'
-          and I have the bearer token "dev-create-endpoint-token"
-         when I POST to the specific path "/data-sets/some-dataset"
-         then the collection called "some-dataset" should exist
+            | key        | value        |
+            | data_group | "data-group" |
+            | data_type  | "data-type"  |
+          and I have JSON data '{"foo":"bar"}'
+          and I use the bearer token for the data_set
+         when I POST to the specific path "/data/data-group/data-type"
+         then I should get back a status of "200"
+        given I have the bearer token "dev-create-endpoint-token"
          when I send a DELETE request to "/data-sets/some-dataset"
          then I should get back a status of "200"
           and I should get back the message "Deleted some-dataset"

tests/write/test_flask_integration.py

@@ -87,15 +87,28 @@ def test_empty_list_gets_accepted(self, store):
     def test_data_gets_stored(self, store):
         self.app.post(
             '/foo_data_set',
-            data = '{"foo": "bar"}',
-            content_type = "application/json",
+            data='{"foo": "bar"}',
+            content_type="application/json",
             headers=[('Authorization', 'Bearer foo_data_set-bearer-token')],
         )
 
         store.assert_called_with(
             [{"foo": "bar"}]
         )
 
+    @fake_data_set_exists("foo_data_set", bearer_token="foo_data_set-bearer-token")
+    @patch("backdrop.core.data_set.DataSet.create_if_not_exists")
+    @patch("backdrop.core.data_set.DataSet.store")
+    def test_data_set_is_created_on_write(self, store, create_if_not_exists):
+        self.app.post(
+            '/foo_data_set',
+            data='{"foo": "bar"}',
+            content_type="application/json",
+            headers=[("Authorization", "Bearer foo_data_set-bearer-token")],
+        )
+
+        create_if_not_exists.assert_called_once_with()
+
     @fake_data_set_exists("foo_data_set", bearer_token="foo_data_set-bearer-token")
     def test_data_with_empty_keys_400s(self):
         response = self.app.post(