fix for auto id bug - verifying test is now passing

alphagov · Sep 23, 2014 · d8e0022 · d8e0022
1 parent fe71e84
commit d8e0022
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/backdrop/core/records.py b/backdrop/core/records.py
@@ -55,7 +55,7 @@ def _generate_auto_id(record, auto_id_keys):
                 ', '.join(missing_keys)))
 
     return b64encode('.'.join(
-        record[key] for key in auto_id_keys))
+        str(record[key]) for key in auto_id_keys))
 
 
 def parse_timestamp(record):

diff --git a/tests/core/test_records.py b/tests/core/test_records.py
@@ -10,7 +10,7 @@ def test__generate_auto_id_generates_auto_ids_correctly_for_standard_case(self):
         assert_that(_generate_auto_id({'foo': 'foo'}, ['foo']), is_('Zm9v'))
 
     def test__generate_auto_id_generates_auto_ids_correctly_for_integers(self):
-        assert_that(_generate_auto_id({'foo': 1}, ['foo']), is_('Zm9v'))
+        assert_that(_generate_auto_id({'foo': 1, 'bar': 'foo'}, ['foo', 'bar']), is_('MS5mb28='))
 
     def test__generate_auto_id_throws_error_when_key_not_matched(self):
         assert_raises(