This repository has been archived by the owner on Mar 24, 2021. It is now read-only.
Fix Bucket name field name #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Bucket.bucket_name field is awkwardly named and doesn't match the naming convetion of BucketConfig.name.
|
Tests passed A-OK on my machine Cap'n, ready to sail. |
|
Please no-one merge just yet, big pull request incoming shortly from @nickgravgaard |
|
Closing until @nickgravgaard's pull request goes through. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Bucket.bucket_name field is awkwardly named and doesn't match the
naming convetion of BucketConfig.name.