This repository has been archived by the owner on Mar 24, 2021. It is now read-only.
Backdrop sends Bearer token to Stagecraft #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| data_sets = _decode_json(_get_url(data_set_url)) | ||
| json_response = _get_json_url( | ||
| data_set_url, self._stagecraft_token) or '[]' |
There was a problem hiding this comment.
Is this correct here? A 404 would imply that you've got the wrong URL path and therefore is an error. No results should return a 200 response containing an empty list.
The `/data-sets` endpoint in Stagecraft is protected by a shared bearer token. Backdrop must send the token when it requests data set metadata from Stagecraft - In `BucketRepository`, send HTTP requests to Stagecraft instead of looking inside Mongo's `buckets` collection. - Selectively handle HTTP 404 from Stagecraft - only `/data-sets/<name>` can legitimately return a 404, all other HTTP errors must bubble up. - Fix `/data-sets/` vs `/data-sets` URL in fake Stagecraft - Added logging on Stagecraft HTTP responses and their JSON content to make them easier to diagnose. - Quite a lot of test refactoring - move unit tests that shouldn't have been put into integration tests for BucketRepository Related to https://www.pivotaltracker.com/story/show/67103208 [#67103208]
robyoung
added a commit
that referenced
this pull request
Mar 18, 2014
Backdrop sends Bearer token to Stagecraft
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
/data-setsendpoint in Stagecraft is protected by a shared bearer token.Backdrop must send the token when it requests data set metadata from
Stagecraft
BucketRepository, send HTTP requests to Stagecraft instead oflooking inside Mongo's
bucketscollection./data-sets/<name>can legitimately return a 404, all other HTTP errors must bubble up.
/data-sets/vs/data-setsURL in fake Stagecraftmake them easier to diagnose.
been put into integration tests for BucketRepository
Related to https://www.pivotaltracker.com/story/show/67103208
[Delivers #67103208]