Adding guidance link #1964
Merged
Adding guidance link #1964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilwoarH
reviewed
Oct 13, 2020
app/views/coronavirus_landing_page/components/shared/_country_section.html.erb
Outdated
Show resolved
Hide resolved
DilwoarH
reviewed
Oct 13, 2020
Comment on lines
9
to
13
| <% if guidance["intro"].present? %> | ||
| <p class="govuk-body"> | ||
| <%= render_govspeak(guidance["intro"]) %> | ||
| <p> | ||
| <% end %> |
There was a problem hiding this comment.
I think this should be moved outside of this if as if there are no links this won't show
There was a problem hiding this comment.
Right, so take this outside of this <% if guidance.present? && guidance["links"].present? %> check? So if the other links aren't present this paragraph will still render?
I'm wondering if the level of abstraction present in this partial could be reduced so there's editable content but it's more reflective of the rendered markup.
DilwoarH
reviewed
Oct 14, 2020
app/views/coronavirus_landing_page/components/shared/_country_section.html.erb
Outdated
Show resolved
Hide resolved
chris-gds
force-pushed
the
landing-page-guidance-link
branch
from
efa86d5
to
fa21222
Compare
DilwoarH
approved these changes
Oct 14, 2020
|
@DilwoarH Ace - would it be possible to merge when ready? I'm not authorised |
chris-gds
force-pushed
the
landing-page-guidance-link
branch
from
f63c7f7
to
eed320b
Compare
Adding new guidance link to landing page Co-authored-by: Dilwoar Hussain <dilwoar.hussain@digital.cabinet-office.gov.uk>
sihugh
force-pushed
the
landing-page-guidance-link
branch
from
eed320b
to
5345d9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why
Trello Ticket
Visual Before
Visual After
Anything else?
Content was updated here (& here) as a precursor.
Actual link directs:
/search/all?level_one_taxon=5b7b9532-a775-4bd2-a3aa-6ce380184b6c&content_purpose_supergroup%5B%5D=guidance_and_regulation&order=most-viewed