Add image_srcset generated from image_url, use in topical events logo #3237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KludgeKML
changed the title
1 task
- Because the filenames for varient image sizes are predictable, we can use them to generate a set of optional images to use as a srcset to try out this technique. - Not quite perfect, but here we allow x2 and x3 image sizes to work with screens with higher pixel density, meaning 300w is x1, 630w is x2 (ish), and 960w is x3 (ish).
KludgeKML
force-pushed
the
topical-events-logo-srcset-spike
branch
from
6a1e901
to
b2f87ee
Compare
KludgeKML
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generates information about other image sizes suitable for using in a srcset
https://trello.com/c/uW5kvqga/1961-using-srcset-functionality-to-make-images-less-blurry-on-govuk