Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx ActionView::Template::Error #3654

Merged

Conversation

unoduetre
Copy link
Contributor

@unoduetre unoduetre commented Jun 11, 2024

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

What

Implement a fix for the following sentry error:

https://govuk.sentry.io/issues/4338933238/?environment=production-eks&environment=production&environment=producton&project=-1&query=is%3Aunresolved&referrer=issue-stream&statsPeriod=24h&stream_index=15

Why

Trello ticket

How

Modify the method latest to use the combined results from methods announcements, publications and statistics (from the same file). Return 3 latest entries (sorted by public_timestamp).

The #latest method now combines announcements, publications and statistics.
This change fixes one of the causes of ActionView::Template::Error.
@govuk-ci govuk-ci temporarily deployed to collections-pr-3654 June 11, 2024 13:29 Inactive
@unoduetre unoduetre marked this pull request as ready for review June 11, 2024 13:33
Copy link
Contributor

@beccapearce beccapearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Might be worth changing the how in the description to something like:
Modify the method latest to use the combined results from methods announcements, publications and statistics (from the same file). Return 3 latest entries (sorted by public_timestamp).

Combine the data from other searches and show the 3 latest ones, as explained in the Definition of Done below.

doesn't make much sense to me without the trello card.

@unoduetre
Copy link
Contributor Author

Looks good.

Might be worth changing the how in the description to something like: Modify the method latest to use the combined results from methods announcements, publications and statistics (from the same file). Return 3 latest entries (sorted by public_timestamp).

Combine the data from other searches and show the 3 latest ones, as explained in the Definition of Done below.

doesn't make much sense to me without the trello card.

You're absolutely right. I've fixed that.

@unoduetre unoduetre merged commit f5c1979 into main Jun 11, 2024
15 checks passed
@unoduetre unoduetre deleted the 2647-sentry-errors-fix-collections-actionviewtemplateerror branch June 11, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants