Skip to content

Commit

Permalink
Fix the running of the E2E tests
Browse files Browse the repository at this point in the history
Previously, the deployed-to-production branch of contacts-admin was
being used for the test, as the repository name/job name is used to
determine what to specify the commit for testing.

This change means that the Publishing E2E tests will actually run with
the version of contacts-admin we're looking to test.

This was noticed as this commit here [1] actually broke the Publishing
E2E tests, but it wasn't noticed before merging.

1: 25408e7
  • Loading branch information
cbaines authored and kevindew committed Nov 8, 2018
1 parent e8a8df7 commit c2705a2
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions Jenkinsfile
Expand Up @@ -4,6 +4,7 @@ library("govuk")

node {
govuk.setEnvar("PUBLISHING_E2E_TESTS_COMMAND", "test-contacts-admin")
govuk.setEnvar("PUBLISHING_E2E_TESTS_APP_PARAM", "CONTACTS_ADMIN_COMMITISH")
govuk.buildProject(
publishingE2ETests: true,
rubyLintDiff: false,
Expand Down

0 comments on commit c2705a2

Please sign in to comment.