This repository has been archived by the owner on Mar 21, 2018. It is now read-only.
Govuk rubocopping #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can run it with `bundle exec govuk-lint-ruby` and append `-a` to autocorrect: https://github.com/alphagov/govuk-lint
| 'value' => 'Neglected%20Tropical%20Diseases' | ||
| } | ||
| 'label' => 'Neglected Tropical Diseases', | ||
| 'value' => 'Neglected%20Tropical%20Diseases' |
There was a problem hiding this comment.
Go home, rubocop. You're drunk.
rgarner
force-pushed
the
govuk-rubocopping
branch
from
2bd1501
to
57943b6
Compare
| @@ -33,11 +33,12 @@ | |||
| results_hash = JSON.parse results_str | |||
| source_array = results_hash.dig "results", "bindings" | |||
|
|
|||
| dest_array = source_array.inject([]) do |dest_array, result| | |||
There was a problem hiding this comment.
Suddenly occurs to me that the removal of this line means that Line 44 will explode with a NameError. Not that we were using this script, but still 😈
(I tend to agree with rubocop/rubocop#1518)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.