This repository has been archived by the owner on Mar 21, 2018. It is now read-only.
Only use broader themes patching SPR #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User research suggests we don't need finer-grained themes yet.
* They did have %20 for space in them; make them similar to other fields by adopting parameterized_form * As a side-effect, separate theme patching/query concerns: create a query when needed, but move that query to the DfidTransition::Extract::Query module.
rgarner
force-pushed
the
only-broad-themes
branch
from
d1c172a
to
8491c24
Compare
* Uses the same query as the SPR patch * Uses the same transforms on the results * Extract those transforms to DfidTransition::Transform::Themes * Remove RDF/XML requires from SPR patcher, as they're only needed in the specs now
Patch the specialist_document schema with the theme enum
* This needs to go in Rummager * Rummager's field defs are global, so make sure this is namespaced
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User research suggests we don't need finer-grained themes yet.
dfid_themegovuk_content_schemas