KBV-366-update-address-confirm-page #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
MattBidewell
commented
May 3, 2022
| } | ||
| locals.currentAddressRowValue = currentAddress.text; | ||
| locals.yearMovedRowValue = currentAddress.addressValidFrom; | ||
| locals.previousAddressRowValue = previousAddress?.text; |
There was a problem hiding this comment.
Setting variables for the govuk summery list here
MattBidewell
commented
May 3, 2022
| @@ -63,7 +64,8 @@ class AddressConfirmController extends BaseController { | |||
| buildingNameNumber = address.buildingName || address.buildingNumber; | |||
| } | |||
|
|
|||
| return `${buildingNameNumber}<br>${address.streetName},<br>${address.addressLocality},<br>${address.postalCode}<br>`; | |||
| const text = `${buildingNameNumber}<br>${address.streetName},<br>${address.addressLocality},<br>${address.postalCode}<br>`; | |||
| return { ...address, text }; | |||
There was a problem hiding this comment.
We're returning the formatted text with the address data now rather than just the formatted text of the address.
MattBidewell
commented
May 3, 2022
| items: [ | ||
| { | ||
| href: "#", | ||
| text: translate("fields.address-confirm.change") |
There was a problem hiding this comment.
This will be added once we add the change links
KaraokeStu
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
What changed
changes to the design of the address confirm page to use the govuk summary component.
These changes are in a list of design changes. Additional logic changes are to come.
Why did it change
Align with design changes.
Issue tracking