Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Fix redirects with missing values #131

Merged
merged 1 commit into from
May 18, 2022
Merged

tests: Fix redirects with missing values #131

merged 1 commit into from
May 18, 2022

Conversation

merlinc
Copy link
Contributor

@merlinc merlinc commented May 17, 2022

Proposed changes

What changed

There were a few oauth tests that weren't running correctly. This refactor adds extra error handling, and fixes the tests to handle the range of cases.

Why did it change

Checklists

Environment variables or secrets

  • No environment variables or secrets were added or changed

Other considerations

  • Update README with any new instructions or tasks

@merlinc merlinc requested a review from a team as a code owner May 17, 2022 17:18
@sonarcloud
Copy link

sonarcloud bot commented May 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

80.0% 80.0% Coverage
0.0% 0.0% Duplication

Base automatically changed from refactor/redis-config to main May 18, 2022 08:51
@merlinc merlinc merged commit 7ed4acc into main May 18, 2022
@merlinc merlinc deleted the fix/oauth-tests branch May 18, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants