refactor: Use common config with express app.set / app.get #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
MattBidewell
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
What changed
This is a bit of a big PR, but it is doing one thing - refactoring common code to use properties set via
expressapp.set('propertyname','propertyvalue').The code to do set these properties can be invoked during server creation, as per
settings.js.At this point, all the code in
/app/oauthcan be moved into a common area. All the code inlib, except forconfigandsettingscan also be moved over. These two files will be different for each credential issuer.Missing tests have also been added.
Any thoughts on naming are welcome.
Why did it change
Issue tracking
Checklists
Environment variables or secrets
Other considerations