app environment variables: use ugly "if" statement to switch these to the .apps.internal addresses for preview only #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
risicle
changed the title
risicle
force-pushed
the
ris-preview-internal-app-urls
branch
2 times, most recently
from
284a87d
to
4c5c387
Compare
|
I've tweaked and tested this and it appears to actually work. |
katstevens
approved these changes
Mar 5, 2019
risicle
force-pushed
the
ris-preview-internal-app-urls
branch
from
4c5c387
to
c081d37
Compare
… the .apps.internal addresses for preview only
This was referenced Mar 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/H53K45It
I apologize for the temporary ugliness of this solution, but it really is meant to be temporary as I switch the environments over to using internal urls one by one.