Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint to email-alert-api to send single email #935

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

1pretz1
Copy link
Contributor

@1pretz1 1pretz1 commented Aug 22, 2019

Copy link
Contributor

@thomasleese thomasleese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This looks good, I've just left a few comments.

app/controllers/alert_controller.rb Outdated Show resolved Hide resolved
app/controllers/alert_controller.rb Outdated Show resolved Hide resolved
config/routes.rb Outdated Show resolved Hide resolved
@1pretz1 1pretz1 force-pushed the create-endpoint-for-alert branch 2 times, most recently from 17c5bcd to e3af75a Compare August 22, 2019 13:27
@1pretz1
Copy link
Contributor Author

1pretz1 commented Aug 22, 2019

@thomasleese ready for review no2

Copy link
Contributor

@thomasleese thomasleese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We might need to make changes in the future as we learn what the email will be like, but I think this is a good start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants