This repository has been archived by the owner on Nov 16, 2021. It is now read-only.
Fix syntax #166
Merged
Fix syntax #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without these parentheses, `fab` fails with:
fab
Traceback (most recent call last):
File "/opt/boxen/homebrew/lib/python2.7/site-packages/fabric/main.py", line 658, in main
docstring, callables, default = load_fabfile(fabfile)
File "/opt/boxen/homebrew/lib/python2.7/site-packages/fabric/main.py", line 165, in load_fabfile
imported = importer(os.path.splitext(fabfile)[0])
File "/Users/matt/govuk/fabric-scripts/fabfile.py", line 25, in <module>
import incident
File "/Users/matt/govuk/fabric-scripts/incident.py", line 3, in <module>
import nginx
File "/Users/matt/govuk/fabric-scripts/nginx.py", line 8
def enable_maintenance:
^
SyntaxError: invalid syntax
|
Might be worth adding a linter and TravisCI to this project. Not as part of this PR, but later.. |
|
Agreed. I'd eventually like to add some tests, too. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without these parentheses,
fabfails with: