Improvements to google_drive_csv_downloader #1619

huwd · 2019-10-03T12:48:20Z

background

The idea of of a one line rake task to speed changes sounded like a great idea,
but I had some problems setting this up.

I think zsh doesn't play nice with normal gets and I couldn't quite grok the documentation to work out what and where everything had to go.

Made a few changes, i hope are improvements and now mean I can run the googleSheetsConnection

adds more detail to documentation about first time setup
adds credential and generated token.yaml file for Google API auth to gitignore
changes use of gets to STDIN.gets to prevent initial try to read file from arg, see here: https://stackoverflow.com/questions/10523536/whats-the-difference-between-gets-chomp-vs-stdin-gets-chomp

benthorner

Looks good to me 🏅.

docs/make-changes-to-brexit-checker-content.md

adds more detail to documentation about first time setup adds credential and generated token.yaml file for Google API auth to gitignore changes use of gets to STDIN.gets to prevent initial try to read file from arg, see here: https://stackoverflow.com/questions/10523536/whats-the-difference-between-gets-chomp-vs-stdin-gets-chomp

huwd requested a review from benthorner October 3, 2019 12:48

huwd self-assigned this Oct 3, 2019

bevanloon temporarily deployed to finder-frontend-pr-1619 October 3, 2019 12:48 Inactive

benthorner approved these changes Oct 3, 2019

View reviewed changes

docs/make-changes-to-brexit-checker-content.md Outdated Show resolved Hide resolved

bevanloon temporarily deployed to finder-frontend-pr-1619 October 3, 2019 13:32 Inactive

huwd force-pushed the googleSheetsConnection branch from cf03015 to e9241ec Compare October 3, 2019 13:33

bevanloon deployed to finder-frontend-pr-1619 October 3, 2019 13:33 View deployment

huwd merged commit 6ad7d0b into master Oct 3, 2019

huwd deleted the googleSheetsConnection branch October 3, 2019 14:13