Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to google_drive_csv_downloader #1619

Merged
merged 1 commit into from Oct 3, 2019

Conversation

@huwd
Copy link
Contributor

commented Oct 3, 2019

background

The idea of of a one line rake task to speed changes sounded like a great idea,
but I had some problems setting this up.

I think zsh doesn't play nice with normal gets and I couldn't quite grok the documentation to work out what and where everything had to go.

Made a few changes, i hope are improvements and now mean I can run the googleSheetsConnection

Changes:

@huwd huwd requested a review from benthorner Oct 3, 2019
@huwd huwd self-assigned this Oct 3, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1619 Oct 3, 2019 Inactive
Copy link
Collaborator

left a comment

Looks good to me 🏅.

docs/make-changes-to-brexit-checker-content.md Outdated Show resolved Hide resolved
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1619 Oct 3, 2019 Inactive
adds more detail to documentation about first time setup

adds credential and generated token.yaml file for Google API auth to gitignore

changes use of gets to STDIN.gets to prevent initial try to read file from arg, see here: https://stackoverflow.com/questions/10523536/whats-the-difference-between-gets-chomp-vs-stdin-gets-chomp
@huwd huwd force-pushed the googleSheetsConnection branch from cf03015 to e9241ec Oct 3, 2019
@huwd huwd merged commit 6ad7d0b into master Oct 3, 2019
3 checks passed
3 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/publishing-e2e-tests Publishing end-to-end tests succeeded on Jenkins
Details
continuous-integration/jenkins/security No security issues found
Details
@huwd huwd deleted the googleSheetsConnection branch Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.