Remove JQuery from EnableAriaControls module #2519
Conversation
We're using an old and unsupported version of jQuery for browser support reasons. Rather than upgrade, it's far better to remove our dependence. jQuery makes writing JavaScript easier, but it doesn't do anything that you can't do with vanilla JavaScript, because it's all written in JavaScript. Once it's removed, we no longer have to worry about upgrading it, and users don't have to download the jQuery library when they visit GOV.UK. Co-authored-by: Andy Sellick <andy.sellick@digital.cabinet-office.gov.uk>
leenagupte
force-pushed
the
convert-enable-aria-controls
branch
from
42174ad
to
66c0d32
Compare
There was a problem hiding this comment.
Code looks peachy.
One non-blocking query I have is what this code is for. I wasn't patient enough to go looking for a live example but from what it looks like, we're sending markup to the frontend with a data-attribute containing aria controls. Why can't we just set aria controls at the template level and bypass the need for this module altogether? Is this a govspeak thing or something?
@owenatgov Thanks for the review. To be honest, I don't know how the code is used. I think perhaps @andysellick might be able to answer the question about why the aria-controls are set as they are. |
Trello: https://trello.com/c/jK6hrK3d
What's changed?
Replace jQuery code in GOV.UK JavaScript (JS) code with vanilla (plain/normal) JavaScript in the EnableAriaControls module.
Why?
We're using an old and unsupported version of jQuery for browser support reasons. Rather than upgrade, it's far better to remove our dependence.
jQuery makes writing JavaScript easier, but it doesn't do anything that you can't do with vanilla JavaScript, because it's all written in JavaScript.
Once it's removed, we no longer have to worry about upgrading it, and users don't have to download the jQuery library when they visit GOV.UK.
Co-authored-by: Andy Sellick andy.sellick@digital.cabinet-office.gov.uk