-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update how users see a change in return results (search filter) #2667
Conversation
Looks great! |
font_size: "s", | ||
margin_bottom: 0 | ||
} %> | ||
</div> | ||
<button class="app-c-button-as-link facets__return-link js-close-filters" type="button"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a button but looks like a link, I'm going to raised as an issue on this one was it's linked into WCAG 1.3.1 however I'm aware there is not a Design for this type of change and is a bigger iteration.
Pre-approving, these small improvements look good / work well |
5c411df
to
a4dde1e
Compare
@maxgds - could you please click merge (if all looks okay)? |
What
h1
Why
Visuals
How to test
Anything else
h1
) with ah2
since this is how no. of results is formatted on larger screens.