Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update how users see a change in return results (search filter) #2667

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

jon-kirwan
Copy link
Contributor

@jon-kirwan jon-kirwan commented Oct 27, 2021

What

  • Display No. of results label on mobile (remove media query) and displayed above the 'filter' button
  • On filter overlay (mobile) display No. of results label below the 'Filter' h1
  • On filter overlay (mobile) remove the number of results text from the submit button so the button text now just reads 'Show search results'

Why

  • Small improvement to GOV.UK Search
  • Especially after making the Search button on the filter screen (in mobile) no longer sticky.
  • Also, addresses an issue, though not a WCAG fail, with information changing on the page automatically after a user interaction.
  • More info about this can be found in the following ticket: https://trello.com/c/1c8oQKhJ

Visuals

Before (all_content_finder) After (all_content_finder)
Before (!all_content_finder) After (!all_content_finder)

How to test

Anything else

  • In the 'filter' overlay view I have marked up the no. of results (e.g. 520,927 results or 7,615 services), which is displayed below the main 'Filter' title (h1) with a h2 since this is how no. of results is formatted on larger screens.
  • I've also moved the skip link component to sit below the newly repositioned 'filter' button (so the tab order is the same as it currently is).

@jon-kirwan jon-kirwan added the do-not-merge Indicates that a PR should not be merged into master / release branches label Oct 27, 2021
@govuk-ci govuk-ci temporarily deployed to finder-front-update-how-d8igg2 October 27, 2021 19:23 Inactive
@jon-kirwan jon-kirwan marked this pull request as ready for review October 28, 2021 06:53
@nnagewad
Copy link

Looks great!

font_size: "s",
margin_bottom: 0
} %>
</div>
<button class="app-c-button-as-link facets__return-link js-close-filters" type="button">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a button but looks like a link, I'm going to raised as an issue on this one was it's linked into WCAG 1.3.1 however I'm aware there is not a Design for this type of change and is a bigger iteration.

@chris-gds
Copy link

Pre-approving, these small improvements look good / work well

@jon-kirwan jon-kirwan force-pushed the Update-how-users-see-a-change-in-return-results branch from 5c411df to a4dde1e Compare November 8, 2021 16:05
@govuk-ci govuk-ci temporarily deployed to finder-front-update-how-d8igg2 November 8, 2021 16:05 Inactive
@jon-kirwan
Copy link
Contributor Author

@maxgds - could you please click merge (if all looks okay)?

@maxgds maxgds merged commit 7618950 into main Nov 8, 2021
@maxgds maxgds deleted the Update-how-users-see-a-change-in-return-results branch November 8, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge Indicates that a PR should not be merged into master / release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants