Remove homepage_controller #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencdaly
force-pushed
the
remove-homepage-controller
branch
from
8143c58
to
b1549b9
Compare
jamie-o-wilkinson
approved these changes
Jul 19, 2024
stephencdaly
force-pushed
the
remove-homepage-controller
branch
from
b1549b9
to
afa52f5
Compare
Now that the groups feature has been enabled, and the code that checks the feature flag has been removed, we can remove the HomepageController and set the app root to the groups index page. This means that visiting `/` directly renders the groups index page. `/groups` also renders the groups index page, and this is where the back links point to. We don't see any issues with this behaviour and it just makes testing slightly easier. Keeping the back links pointing to `/groups` also means that if we update the homepage in future, there will be fewer changes to make.
stephencdaly
force-pushed
the
remove-homepage-controller
branch
from
afa52f5
to
3189e7a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/tRzLMO7a/1612-remove-homepagecontroller-from-forms-admin
Now that the groups feature has been enabled, and the code that checks the feature flag has been removed, we can remove the HomepageController and set the app root to the groups index page.
This means that visiting
/directly renders the groups index page./groupsalso renders the groups index page, and this is where the back links point to. We don't see any issues with this behaviour and it just makes testing slightly easier.Keeping the back links pointing to
/groupsalso means that if we update the homepage in future, there will be fewer changes to make.Things to consider when reviewing