Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align form creation with the prototype #50

Merged
merged 3 commits into from
Jun 7, 2022

Conversation

DavidBiddle
Copy link
Contributor

What problem does the pull request solve?

Closes #41

This cleans up the HTML for the Create and Edit pages, and adds tests. This doesn't strictly match the design in the prototype - since we've currently got two form fields on this page, we have to mark it up slightly differently to comply with the design system, and I've prioritised compliance over visual fidelity here. Once we remove the email field from this page, we can change the design to match the prototype more closely.
The tests don't cover the email field, since we know we're going to get rid of this in the near future.

Checklist

  • I've used the pull request template
  • I've linked this PR to the relevant issue (if mission work)
  • I've written unit tests for these changes (if code change)
  • [n/a] I've updated the documentation in (If any documentation requires updating)

@DavidBiddle DavidBiddle requested a review from a team as a code owner June 1, 2022 15:35
@DavidBiddle DavidBiddle changed the title 41 align form creation with the prototype Align form creation with the prototype Jun 1, 2022
@DavidBiddle DavidBiddle merged commit cb584ae into main Jun 7, 2022
@DavidBiddle DavidBiddle deleted the 41-align-form-creation-with-the-prototype branch June 7, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align form creation with the prototype
2 participants