Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Jest with Vitest for JavaScript testing #370

Merged

Conversation

aliuk2012
Copy link
Contributor

@aliuk2012 aliuk2012 commented Jun 11, 2024

Related to

What problem does this pull request solve?

See related PR for more information. Review the last three commits which relate to this PR.

Trello card:

Things to consider when reviewing

  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

@aliuk2012 aliuk2012 marked this pull request as ready for review June 11, 2024 10:19
@aliuk2012 aliuk2012 changed the title Replace Jest with Vitest for JavaScript testing BLOCKED - Replace Jest with Vitest for JavaScript testing Jun 11, 2024
@aliuk2012 aliuk2012 changed the title BLOCKED - Replace Jest with Vitest for JavaScript testing Replace Jest with Vitest for JavaScript testing Jun 12, 2024
@aliuk2012
Copy link
Contributor Author

@thomasiles @DavidBiddle this PR is now ready for a review. I think this is the last one so all the repos should now be using vitest instead of jest

@DavidBiddle DavidBiddle self-requested a review June 12, 2024 15:19
Copy link
Contributor

@DavidBiddle DavidBiddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! 🎉

@DavidBiddle DavidBiddle merged commit a99be25 into alphagov:main Jun 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants