Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page count is incorrect #32

Closed
DavidBiddle opened this issue May 4, 2022 · 0 comments · Fixed by #34
Closed

Page count is incorrect #32

DavidBiddle opened this issue May 4, 2022 · 0 comments · Fixed by #34
Labels
bug Something isn't working
Projects
GOV.UK Forms Dev

Comments

@DavidBiddle
Copy link
Contributor

The page count is off by one - for example the form below has 2 pages, but is showing as a '3 page draft form'.

This is possibly related to removing start pages from the prototype.

image
@DavidBiddle DavidBiddle added this to To Do in GOV.UK Forms Dev via automation May 4, 2022
@DavidBiddle DavidBiddle added the bug Something isn't working label May 4, 2022
DavidBiddle added a commit that referenced this issue May 5, 2022
@DavidBiddle
Fix page numbering off-by-one error (#32)
33cdbee
@DavidBiddle DavidBiddle mentioned this issue May 5, 2022
Merged
4 tasks
@DavidBiddle DavidBiddle moved this from To Do to Doing in GOV.UK Forms Dev May 5, 2022
GOV.UK Forms Dev automation moved this from Doing to Done May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
GOV.UK Forms Dev
💰 Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix page numbering off-by-one error (#32) alphagov/forms-prototypes
1 participant
@DavidBiddle