Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't print share links #258

Merged
merged 1 commit into from Feb 27, 2017
Merged

Don't print share links #258

merged 1 commit into from Feb 27, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Feb 27, 2017

  • The links aren’t useful when printed
  • The long dynamic URLs don’t read well

(This also highlights that when printing there is no clear "end of content" point)

Before

screen shot 2017-02-27 at 14 39 35

After

screen shot 2017-02-27 at 14 40 52

* The links aren’t useful when printed
* The long dynamic URLs don’t read well
@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-258 Feb 27, 2017 Inactive
Copy link
Contributor

@nickcolley nickcolley left a comment

Great work, print pages getting ❤️ 👍

@nickcolley nickcolley merged commit 46a1d79 into master Feb 27, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new vulnerabilities
Details
@nickcolley nickcolley deleted the dont-print-share-links branch Feb 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.