Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't print share links #258

Merged
merged 1 commit into from Feb 27, 2017
Merged

Don't print share links #258

merged 1 commit into from Feb 27, 2017

Conversation

fofr
Copy link
Contributor

@fofr fofr commented Feb 27, 2017

  • The links aren’t useful when printed
  • The long dynamic URLs don’t read well

(This also highlights that when printing there is no clear "end of content" point)

Before

screen shot 2017-02-27 at 14 39 35

After

screen shot 2017-02-27 at 14 40 52

@fofr
Don't print share links
0012c76 
* The links aren’t useful when printed
* The long dynamic URLs don’t read well
@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-258 February 27, 2017 14:41 Inactive
NickColley
NickColley approved these changes Feb 27, 2017
View reviewed changes
Copy link
Contributor

@NickColley NickColley left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, print pages getting ❤️ 👍

@NickColley NickColley merged commit 46a1d79 into master Feb 27, 2017
@NickColley NickColley deleted the dont-print-share-links branch February 27, 2017 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickColley NickColley NickColley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fofr @NickColley @boffbowsh