Configure AssetHelper to load individual stylesheets #2734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jon-kirwan
force-pushed
the
configure-asset-helper-to-load-individual-stylesheets
branch
from
ff7663a
to
bec8b2c
Compare
jon-kirwan
force-pushed
the
configure-asset-helper-to-load-individual-stylesheets
branch
from
c799688
to
f2627cd
Compare
jon-kirwan
force-pushed
the
configure-asset-helper-to-load-individual-stylesheets
branch
from
e540251
to
f198c6f
Compare
jon-kirwan
force-pushed
the
configure-asset-helper-to-load-individual-stylesheets
branch
from
f198c6f
to
88df77f
Compare
jon-kirwan
force-pushed
the
configure-asset-helper-to-load-individual-stylesheets
branch
from
84a7a61
to
d37b24c
Compare
jon-kirwan
force-pushed
the
configure-asset-helper-to-load-individual-stylesheets
branch
from
d37b24c
to
925b699
Compare
jon-kirwan
force-pushed
the
configure-asset-helper-to-load-individual-stylesheets
branch
from
925b699
to
aecf4c0
Compare
jon-kirwan
force-pushed
the
configure-asset-helper-to-load-individual-stylesheets
branch
from
aecf4c0
to
1a8ef95
Compare
jon-kirwan
force-pushed
the
configure-asset-helper-to-load-individual-stylesheets
branch
from
1a8ef95
to
8951e0f
Compare
jon-kirwan
force-pushed
the
configure-asset-helper-to-load-individual-stylesheets
branch
from
8951e0f
to
d4db00b
Compare
jon-kirwan
force-pushed
the
configure-asset-helper-to-load-individual-stylesheets
branch
from
d4db00b
to
b0fd09e
Compare
jon-kirwan
force-pushed
the
configure-asset-helper-to-load-individual-stylesheets
branch
from
b0fd09e
to
d2bb38a
Compare
jon-kirwan
force-pushed
the
configure-asset-helper-to-load-individual-stylesheets
branch
from
d2bb38a
to
f5962e1
Compare
MartinJJones
approved these changes
Jun 5, 2023
jon-kirwan
force-pushed
the
configure-asset-helper-to-load-individual-stylesheets
branch
from
f5962e1
to
7e7f81e
Compare
jon-kirwan
deleted the
configure-asset-helper-to-load-individual-stylesheets
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
https://trello.com/c/fc41oyEK/1923-enable-individual-loading-of-stylesheets-in-government-frontend
Changes to load component and view style sheets only required on the page being viewed. For example, CSS for
_detailed-guideonly loads on the following page type e.g. waste exemption: NWFD 2 temporary storage at the place of production.Why
This reduces the amount of CSS required for each page and increases the ability of a browser to cache the stylesheets - this should mean a faster load time for both first time and repeat visitors.
See RFC #149 for more details.
Review URL(s)
Service manual
Manuals
HMRC manuals
Visual changes
None
Prerequisites
Conditionally load componentsMove text direction stylesTurn digests back on in test environmentAdd Govspeak componentAdd missing govuk-link link formattingMove organisation-links helper alongside corporate information page view stylesMove service manual guide modules alongside respective view stylesReplace white-links helper with Design System mixinRemove unused helpersReplace consultation view styles with Design System stylesExtract published dates button group shared stylesRemove unused view stylesAnything else