Use London timezone #320
Merged
Use London timezone #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most dates in content items are UTC, occasionally some are BST. Any UTC dates during daylight savings time would render an hour out – when the time is around midnight, then the date will also be wrong: https://govuk.zendesk.com/agent/tickets/2044273 * Use London timezone * Update all uses of Time.parse to Time.zone.parse * Replace DateTime.parse with Time.zone.parse * Fix tests now they correctly handle the daylight savings time (DST) * Include comment about far future dates having no DST * Update tests to use times in November in GMT, not BST (this has highlighted an odd usage of daylight savings timezones during a non DST time period in the content schema examples – e.g. 4 Nov is in BST, but that’s not in a DST period)
|
This looks great 👍 |
NickColley
approved these changes
Apr 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most dates in content items are UTC, occasionally some are BST. Any UTC dates during daylight savings time would render an hour out – when the time is around midnight, then the date will also be wrong.
How bug appeared
via https://govuk.zendesk.com/agent/tickets/2044273
On: https://www.gov.uk/government/publications/your-new-state-pension-explained
Those two dates are the same when taking into account time zone. But they rendered as:
Fix
highlighted an odd usage of daylight savings timezones during a non DST
time period in the content schema examples – e.g. 4 Nov is in BST, but
that’s not in a DST period)