Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style buttons in govspeak as start buttons #349

Merged
merged 1 commit into from May 8, 2017
Merged

Style buttons in govspeak as start buttons #349

merged 1 commit into from May 8, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented May 8, 2017

Publishers copy and paste markup into mainstream content to render
buttons. Buttons should be a markdown pattern/component/combination.

  • For now, make sure they render correctly so we can switch guides
  • Fix bug on live where focus/active state shows in blue (Element button styles aren’t specific enough to override govspeak ones)
  • Rename button-info to button-info-text so it’s not confused as a button type.

Steps to take after this:

  • Add markdown pattern for buttons and start buttons
  • Move styling of buttons into static component that can be shared with govspeak

Before

screen shot 2017-05-08 at 12 24 49

After

screen shot 2017-05-08 at 12 24 11

@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-349 May 8, 2017 Inactive
Publishers copy and paste markup into mainstream content to render
buttons. Buttons should be a markdown pattern/component/combination.

* For now, make sure they render correctly so we can switch guides
* Fix bug on live where focus/active state shows in blue (Element
button styles aren’t specific enough to override govspeak ones)
* Rename `button-info` to `button-info-text` so it’s not confused as a
button type.
Copy link
Contributor

@nickcolley nickcolley left a comment

Let's talk about how we do the next actions in this PR soon, this looks good for now.

@fofr fofr merged commit a4c5b04 into master May 8, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new vulnerabilities
Details
@fofr fofr deleted the tweak-guide-buttons branch May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.