Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn up slimmer to 11, update nokogiri to 1.8 and minor Rails bump #439

Merged
merged 4 commits into from Aug 14, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Aug 11, 2017

  • Bump slimmer to v11 to pickup latest nokogiri
  • Requires a bump to wraith major version
  • Requires minor bump to rails-dom-testing
  • Bumping only rails-dom-testing and minitest surfaced a bug in Rails: rails/rails#29022
    • Bump rails patch version to address bug fix
  • Fix assert_nil deprecation warnings in updated minitest
fofr added 3 commits Aug 11, 2017
* Bump slimmer to v11 to pickup latest nokogiri
* Requires a bump to wraith major version
* Requires minor bump to rails-dom-testing
(This will fail in Minitest 6)
Bumping only rails-dom-testing and minitest surfaced a bug in Rails:
rails/rails#29022

Bump rails patch version to address bug fix
@fofr
Copy link
Contributor Author

@fofr fofr commented Aug 11, 2017

Tests are failing because of searls/jasmine-rails#213

Re-enable when jasmine-rails can be patched
@fofr fofr merged commit 3a3eb31 into master Aug 14, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new vulnerabilities
Details
@fofr fofr deleted the upgrade-slimmer branch Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.