Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow td and th elements without a style attribute #73

Merged
merged 2 commits into from May 3, 2016
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented May 3, 2016

If no style was included node['style'].match returned a no method error, so normal tables wouldn’t work correctly.

fofr added 2 commits May 3, 2016
If no `style` was included `node['style'].match` returned a no method
error, so normal tables wouldn’t work correctly.
Test names stated `th` and `td`, but didn’t test for them.
@boffbowsh
Copy link
Contributor

@boffbowsh boffbowsh commented May 3, 2016

Merge when 💚

@fofr fofr merged commit a5f8e05 into master May 3, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@fofr fofr deleted the fix-table-check branch May 3, 2016
fofr added a commit that referenced this pull request May 3, 2016
Yank version 3.6.0 because of #73 (td and th elements without a style
attribute would error)
@fofr fofr mentioned this pull request May 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.