This repository has been archived by the owner on Nov 2, 2021. It is now read-only.
Add aria labels to account manager nav elements #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danacotoran
force-pushed
the
account-navigation-aria-labels
branch
from
ecaa274
to
971e79a
Compare
The account manager prototype currently had two navigation landmarks, one being in the site header, and another being the account menu. WCAG SC 2.4.1 states that when there are multiple navigation landmarks of the same kind on a page, they should be labelled in order to help assistive tech users differentiate between them. This adds relevant labels to these landmarks to improve navigation for screen reader users.
danacotoran
force-pushed
the
account-navigation-aria-labels
branch
from
971e79a
to
39471c3
Compare
andysellick
approved these changes
Jan 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The account manager prototype currently has two navigation landmarks, one being in the site header, and another being the account menu.
WCAG SC 2.4.1 states that when there are multiple navigation landmarks of the same kind on a page, they should be labelled in order to help assistive tech users differentiate between them.
This adds relevant labels to these landmarks to improve navigation for screen reader users.
✨ Important: ✨ depends on this PR which introduces the ability to pass a custom aria label to the
layout_headercomponent.Before: not labelled, both
navs just say NavigationAfter:
navs have labels, therefore they are clearerhttps://trello.com/c/1cnffruq