Fix regex misuse. #199
Merged
Fix regex misuse. #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Overbroad matching of hostnames: `.` vs `\.` - Overuse of `RegExp.prototype.match` where `String.prototype.includes` or `RegExp.prototype.test` suffice and better communicate the intent by returning a boolean. - Use `Location.hostname` and not `Location.host`, because we're already assuming there isn't a port on the end (e.g. `:8080`). This avoids further complicating the (corrected) regexes. Should resolve: - https://github.com/alphagov/govuk-browser-extension/security/code-scanning/1 - https://github.com/alphagov/govuk-browser-extension/security/code-scanning/2 - https://github.com/alphagov/govuk-browser-extension/security/code-scanning/3 - https://github.com/alphagov/govuk-browser-extension/security/code-scanning/4 I don't believe these are exploitable, hence raising a regular PR.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Otherwise we just substitute one CodeQL warning for another :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.vs\.RegExp.prototype.matchwhereString.prototype.includesorRegExp.prototype.testsuffice and better communicate the intent by returning a boolean.Location.hostnameand notLocation.host, because we're already assuming there isn't a port on the end (e.g.:8080). This avoids further complicating the (corrected) regexes.Stringand we're trying to match on the hostname, just parse it properly withURL.Should resolve:
I don't believe these are exploitable, hence raising a regular PR.