This repository has been archived by the owner on Sep 5, 2023. It is now read-only.
Use original client IP when checking ACLs #362
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we used "client.ip" to control access to Staging and Integration, but this won't work for GOV.UK Alerts, since the IP gets modified due to its use of the shielding feature [1]. This moves setting the existing Fastly-Client-IP header earlier so that we can reuse it as a reliable means of checking who's allowed in. [1]: https://developer.fastly.com/reference/vcl/variables/client-connection/client-ip/
benthorner
force-pushed
the
fix-govuk-alerts-staging
branch
from
cc8b0fa
to
65e2443
Compare
|
Closing as this isn't something we're actively working on. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/179659713
Previously we used "client.ip" to control access to Staging and
Integration, but this won't work for GOV.UK Alerts, since the IP
gets modified due to its use of the shielding feature 1. This
moves setting the existing Fastly-Client-IP header earlier so that
we can reuse it as a reliable means of checking who's allowed in.
Disclaimer: I haven't tested this, since I don't have access to do
so. I'm fairly confident the header will always be set, so I don't
expect any of the subsequent uses of it to fail.