Fix basic ruby violations

Gemfile

@@ -12,12 +12,12 @@ gem 'uglifier', '>= 1.3.0'
 gem 'jbuilder', '~> 2.0'
 
 # bundle exec rake doc:rails generates the API under doc/api.
-gem 'sdoc', '~> 0.4.0',        group: :doc
+gem 'sdoc', '~> 0.4.0', group: :doc
 
 gem 'kramdown', '1.5'
 
 if ENV['SLIMMER_DEV']
-  gem 'slimmer', :path => '../slimmer'
+  gem 'slimmer', path: '../slimmer'
 else
   gem 'slimmer', '9.1.0'
 end

app/controllers/application_controller.rb

@@ -7,8 +7,8 @@ class ApplicationController < ActionController::Base
 
   before_filter :set_custom_slimmer_headers
 
-
 private
+
   def set_custom_slimmer_headers
     set_slimmer_headers(report_a_problem: 'false')
   end

app/controllers/components_controller.rb

@@ -1,7 +1,6 @@
 require 'component'
 
 class ComponentsController < ApplicationController
-
   def show
     @component = Component.get(params[:id])
   end

app/controllers/fixtures_controller.rb

@@ -1,21 +1,20 @@
 require 'component'
 
 class FixturesController < ApplicationController
-
   def show
-    @fixture =  component.fixtures.select {|f|
+    @fixture = component.fixtures.find {|f|
       f.id == params[:id]
-    }.first
+    }
   end
 
   def index
     @fixtures = component.fixtures
   end
 
   def preview
-    @fixture =  component.fixtures.select {|f|
+    @fixture = component.fixtures.find {|f|
       f.id == params[:fixture_id]
-    }.first
+    }
     render layout: 'preview'
   end
 

app/models/component.rb

@@ -1,6 +1,6 @@
 Component = Struct.new(:id, :name, :description, :body, :fixtures) do
   def self.get(id)
-    all.select { |component| component.id == id }.first
+    all.find { |component| component.id == id }
   end
 
   def self.all
@@ -28,7 +28,7 @@ def self.fetch_component_doc
     begin
       JSON.parse(
         RestClient.get(component_doc_url).body,
-        {symbolize_names: true}
+        symbolize_names: true
       )
     rescue RestClient::BadGateway => e
       raise "#{e} from #{Plek.current.find('static')} - is static running?"

bin/rails

@@ -3,6 +3,6 @@ begin
   load File.expand_path("../spring", __FILE__)
 rescue LoadError
 end
-APP_PATH = File.expand_path('../../config/application',  __FILE__)
+APP_PATH = File.expand_path('../../config/application', __FILE__)
 require_relative '../config/boot'
 require 'rails/commands'

config.ru

@@ -1,4 +1,4 @@
 # This file is used by Rack-based servers to start the application.
 
-require ::File.expand_path('../config/environment',  __FILE__)
+require ::File.expand_path('../config/environment', __FILE__)
 run Rails.application

config/environments/test.rb

@@ -13,7 +13,7 @@
   config.eager_load = false
 
   # Configure static asset server for tests with Cache-Control for performance.
-  config.serve_static_files  = true
+  config.serve_static_files = true
   config.static_cache_control = 'public, max-age=3600'
 
   # Show full error reports and disable caching.

config/initializers/cookies_serializer.rb

@@ -1,3 +1,3 @@
 # Be sure to restart your server when you modify this file.
 
-Rails.application.config.action_dispatch.cookies_serializer = :json
+Rails.application.config.action_dispatch.cookies_serializer = :json

config/routes.rb

@@ -1,5 +1,4 @@
 Rails.application.routes.draw do
-
   get 'about' => 'about#index'
 
   resources :components, only: [:index, :show] do

test/controllers/about_controller_test.rb

@@ -5,5 +5,4 @@ class AboutControllerTest < ActionController::TestCase
     get :index
     assert_response :success
   end
-
 end

test/controllers/components_controller_test.rb

@@ -10,5 +10,4 @@ class ComponentsControllerTest < ActionController::TestCase
     get :show, id: 'title'
     assert_response :success
   end
-
 end

test/controllers/fixtures_controller_test.rb

@@ -7,8 +7,7 @@ class FixturesControllerTest < ActionController::TestCase
   end
 
   test "should get show" do
-    get :show, {component_id: 'title', id: 'default'}
+    get :show, component_id: 'title', id: 'default'
     assert_response :success
   end
-
 end

test/controllers/welcome_controller_test.rb

@@ -5,5 +5,4 @@ class WelcomeControllerTest < ActionController::TestCase
     get :index
     assert_response :success
   end
-
 end