Upgrade to accessible-autocomplete v2.0.0 #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Colin Rotherham <work@colinr.com>
Signed-off-by: Colin Rotherham <work@colinr.com>
Signed-off-by: Colin Rotherham <work@colinr.com>
Not styled, but good for reference Signed-off-by: Colin Rotherham <work@colinr.com>
injms
approved these changes
Sep 27, 2019
injms
reviewed
Sep 27, 2019
CHANGELOG.md
Outdated
| @@ -2,6 +2,12 @@ | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| ## 1.0.0 - 2019-09-27 | |||
There was a problem hiding this comment.
Only one thing - can you put this under 'Unreleased'? Then I'll a separate pull request specifically to bump the version number.
There was a problem hiding this comment.
@injms Done 👍
|
Thanks @injms. I've (assumed) this will need to be a breaking v1.0.0 release, but let me know if you need anything changing in the changelog etc. Do you want me to run |
Now using CSS from the GOV.UK Design System Signed-off-by: Colin Rotherham <work@colinr.com>
NickColley
approved these changes
Sep 27, 2019
There was a problem hiding this comment.
Thanks a lot for helping with this Colin 👍
@injms the Design System team can release this if you are not able to or are busy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change that now uses GOV.UK Design System CSS.
E.g. The focus state now meets the new WCAG 2.1 level AA requirements.
See Accessible Autocomplete v2.0.0 release notes:
https://github.com/alphagov/accessible-autocomplete/releases/tag/v2.0.0
Fixes #59 the Babel config issue by adding
corejsversion.