Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider including link states for normal and inverted links in the typography guidance #1859

Closed
2 of 4 tasks
CharlotteDowns opened this issue Sep 7, 2021 · 1 comment
Closed
2 of 4 tasks

Comments

@CharlotteDowns
Copy link
Contributor

CharlotteDowns commented Sep 7, 2021

What

Consider including link states for normal and inverted links in the typography guidance.

Why

A user was looking for more information on link states for inverted links as they wanted to use an interrupt card in their service.

We don't provide much guidance on what links should look like when using :visited , :hover, :active states. Looking at an unvisited state for an inverted link may lead us to create guidance like this.

Further detail

Our visited state for non inverted links is currently set by the browser.

Who needs to know about this

Designers

Done when

  • we decide whether to add a class for visited states for inverted links
  • we decide whether to add guidance about link states to the typography section
  • styles created and added for visited inverted links
  • content drafted for guidance
@CharlotteDowns
Copy link
Contributor Author

What we have decided

  • We will keep using the default styles set by the browser for :visited states as we cannot be sure that inverted links will always be used on a blue background.
  • The Design System usually provides coded examples to show states and other interactions. Keeping this in mind we have chosen not to add specific guidance around states to the typography section but will reopen this thought if users think it would be useful.

@CharlotteDowns CharlotteDowns moved this from Small stories ⏱ to Done 🏁 in Design System Sprint Board Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants