Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve "blocking" decisions #3816

Closed
1 task done
Tracked by #3795
CharlotteDowns opened this issue May 28, 2024 · 1 comment
Closed
1 task done
Tracked by #3795

Resolve "blocking" decisions #3816

CharlotteDowns opened this issue May 28, 2024 · 1 comment

Comments

@CharlotteDowns
Copy link
Contributor

CharlotteDowns commented May 28, 2024

What

Resolve "blocking" decisions needed for the code/design – see comment

Outstanding decisions:

  • naming of components and parts (e.g. service header)
  • styling of service name link
  • response to accessibility issues (e.g. placement of links on desktop)

Why

To help us build Navigation that resolves all issues we've become aware of.

Done when

  • Documented all resolutions
@CharlotteDowns CharlotteDowns changed the title Resolve "blocking" decisions needed for the code/design – [see comment](https://github.com/alphagov/govuk-design-system/issues/3795#issuecomment-2115245135)) Resolve "blocking" decisions Jun 4, 2024
@CharlotteDowns CharlotteDowns self-assigned this Jun 4, 2024
@CharlotteDowns
Copy link
Contributor Author

Decisions

Here is our decision log for other relevant decisions and resolutions.

Naming of components and parts (e.g. service header)

We ran this decision as a question to our steering group and wider community. The consensus was to call the components and pattern the following:

'GOV.‌UK header' component, 'Service header navigation' component and 'Help users navigate a service' pattern

Styling of service name link

We asked the community to help us decide whether we should make the service name a link in all instances. If the decision is 'Yes' we will not change the styling of the service name link as the behaviour will always be the same.

Response to accessibility issues (e.g. placement of links on desktop)

I've added a comment about left-aligning navigation on desktop in issue #3811. I think on desktop we are ok to leave it the way it is currently built with flex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant