-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examine and resolve accessibility findings #3811
Comments
I have a PR for the breadcrumb labelling open here: alphagov/govuk-frontend#4995 |
That wouldn't solve the issue when what's in between is other things in the global header, like the One Login menu. |
@selfthinker Is the phase banner issue still unsolved if we use option H. Generic landmark for the whole service header in this google document and suggested the phase banner live within this landmark? |
@CharlotteDowns, that particular accessibility issue with the phase banner would be solved by option H, using a generic landmark for the service header. It might still be visually or structurally confusing to have the phase banner between global and service header, but that's then a potential usability, not accessibility issue. |
With the help of @patrickpatrickpatrick I've been looking at putting the phase banner between the service name and the navigation in a hope that this, Here is a screenshot of an example where the phase banner is between the service name and the service navigation. Will this change in landmarks also help resolve 'NVDA in Chrome behaving weird'? |
I just also found this accessibility concern Review the use of |
That generally looks good to me. I would probably choose to use
I doubt it. |
That seems to be quite complicated. From what I can tell that is pretty unconventional code. I don't think we use any such behaviour in the new component, so I don't think it is relevant. |
We can suggest the phase banner comes after the navigation but still included in the 'Service information and navigation'.cc: @querkmachine @domoscargin for next cycle?? |
Further to the discussion on Phase banner placement. We have come to the conclusion that the Phase banner should come after the service header and navigation component, ideally wrapped in a Here is a sketch plan for the order of things that could appear in both the GOV.UK header component and the Service header navigation component. The possible objections to the approach have been that it could be deemed that a section of the website is at a certain phase rather than the service entirely. However, we wish to justify this by acknowledging that the Phase banner will persist across all pages of the service in this location and that the content within the component mentions it is service-wide.
|
I looked into this. It turns out that some of this was fixed in Chrome version 125, so was present until version 124. Due to the recent changes in the code, the service name is now read out, but all the navigation items are still read in one go up until version 124. This problem appears whenever list items are set to An NVDA bug report suggests that this is intended behaviour. While I get their point that any elements in an |
I made the change suggested above, and although it resolved the issue of NVDA reading all of the links out in one go, it introduced a new problem of NVDA announcing the empty text node between each nav item. This required users of arrow navigation to press twice in order to move from one link to the next.
I've instead changed the navigation list to use a flexbox. This removes the empty text nodes, and also seems to prevent the navigation items from being read as a single unit. @selfthinker Quickly devtesting this, I've not found any obvious issues created by making the list a flexbox. Do you think it's worth retesting the component due to this change? |
What
Examine and resolve accessibility findings from accessibility specialist report
Why
To ensure the Navigation component is accessible for as many users as possible.
Who needs to be involved
Developers, Designers (to help with decisions)
Who needs to review
Accessibility specialist
Done when
The text was updated successfully, but these errors were encountered: