Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform browser testing on Service Header component #3836

Closed
3 tasks done
Tracked by #3835
querkmachine opened this issue Jun 17, 2024 · 2 comments
Closed
3 tasks done
Tracked by #3835

Perform browser testing on Service Header component #3836

querkmachine opened this issue Jun 17, 2024 · 2 comments

Comments

@querkmachine
Copy link
Member

querkmachine commented Jun 17, 2024

What

Test the Service Header component in the browsers in GOV.UK Frontend's support remit.

We now use a graded system for determining browser support, so there isn't a definitive list of browser versions to test outside of some lower bounds. See our browser support documentation for information on how graded support works.

Assistive technology testing is covered by #3811.

Why

The Service Header is a major new component and should ideally work in as many contexts as possible.

Who needs to work on this

  • Developers

Who needs to review this

  • Developers

Done when

  • A testing grid has been put together
  • All browsers and scenarios in the testing grid have been tested
  • Any issues encountered have been fixed or raised as new issues
@querkmachine
Copy link
Member Author

I've started testing and recording the results in this spreadsheet (internal only).

@querkmachine
Copy link
Member Author

There were two issues identified in the initial round of browser testing, which only covered a subset of those in the testing grid.

  • At certain viewport sizes, the service name and navigation menu could collide due to a lack of margin being defined between them. This occurred on all browsers.
  • On Internet Explorer 11, long navigation menus would not wrap and would continue off the side of the viewport, introducing a horizontal scrollbar.

Both of these issues were subsequently fixed.

I've now retested the component against all the browsers in the grid. There were two browsers that I was unable to test: Safari 17.2 (macOS) and Safari 10.3 (iOS) due to these browsers being unavailable or unusable in Browserstack. I have found no issues with the other browsers tested.

(N.B. We make no guarantees that Grade C and X browsers will receive manual testing or will look/behave the same as other browsers.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 🏁
Development

No branches or pull requests

3 participants