Document how to add an attribute to template <body> #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can preview this change here: Built with commit 8b4f26c https://deploy-preview-1071--govuk-design-system-preview.netlify.com |
m-green
reviewed
Oct 29, 2019
| @@ -117,6 +117,11 @@ Variables can be set with: | |||
| <td class="govuk-table__cell">Add a class to the <code><body></code> element.</td> | |||
| </tr> | |||
|
|
|||
| <tr class="govuk-table__row"> | |||
| <td class="govuk-table__cell">bodyAttributes</td> | |||
| <td class="govuk-table__cell">Add an attribute to the <code><body></code> element.</td> | |||
There was a problem hiding this comment.
Couple of changes suggested, because:
- "an attribute" didn't seem accurate because you can add more than one
- I think it's worth clarifying how to add each attribute, because
bodyAttributeuses key-value pairs rather than a single value.
Suggested change
| <td class="govuk-table__cell">Add an attribute to the <code><body></code> element.</td> | |
| <td class="govuk-table__cell">Add attributes to the <code><body></code> element. Add each attribute and its value as a key value pair in the `bodyAttributes` object.</td> |
NickColley
approved these changes
Oct 29, 2019
m-green
approved these changes
Oct 30, 2019
|
Thanks @m-green 👍 Just need to wait for alphagov/govuk-frontend#1623 to be released and then this can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked until alphagov/govuk-frontend#1623 is released