Clarify guidance on image alt text #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ You can preview this change here: 🔨 Explore the source changes: 4d93148 🔍 Inspect the deploy logs: https://app.netlify.com/sites/govuk-design-system-preview/deploys/6006eb02ec2d1a0007e0116e 😎 Browse the preview: https://deploy-preview-1445--govuk-design-system-preview.netlify.app |
CharlotteDowns
approved these changes
Jan 19, 2021
calvin-lau-sig7
approved these changes
Jan 19, 2021
36degrees
approved these changes
Jan 19, 2021
The following two lines are mutually contradictory: - repeat information from the page - include extra information not on the page What you should say is don't include extra info that isn't showing in the image!
|
I've rebased to bring in the changes from #1442 so that the required status checks pass – although I think GitHub is currently having issues so the pull request has not updated yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following two lines under the "Do not" heading are mutually contradictory:
What you should say is, don't include extra info that is not in the image