Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make layout names consistent #1895

Closed
wants to merge 1 commit into from
Closed

Conversation

matteason
Copy link
Contributor

Updated 'two-thirds and one-third' to 'two-thirds / one-third' to make it consistent with how the layout is named on the rest of the page.
Moved "layout" out of the quotes because it applies to both options, not just the second one

Updated 'two-thirds and one-third' to 'two-thirds / one-third' to make it consistent with how the layout is named on the rest of the page.
Moved "layout" out of the quotes because it applies to both options, not just the second one
@netlify
Copy link

netlify bot commented Sep 23, 2021

✔️ You can preview this change here:
Built without sensitive environment variables

🔨 Explore the source changes: 4ec04f8

🔍 Inspect the deploy log: https://app.netlify.com/sites/govuk-design-system-preview/deploys/614cb1453a6e640007bd43f6

😎 Browse the preview: https://deploy-preview-1895--govuk-design-system-preview.netlify.app

Copy link
Contributor

@vanitabarrett vanitabarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @matteason , this change makes sense to me but I've asked Calvin (our content designer) to take a look too.

@calvin-lau-sig7 calvin-lau-sig7 linked an issue Sep 27, 2021 that may be closed by this pull request
3 tasks
@calvin-lau-sig7
Copy link
Contributor

Hi, it looks like the name of this layout is inconsistent all down the page. I'm going to take a wider look at this in our guidance (probably along with @EoinShaughnessy on technical docs) to decide and implement a consistent term for this.

@matteason
Copy link
Contributor Author

That makes sense, thanks @calvin-lau-sig7. I'll close off this PR

@matteason matteason closed this Sep 27, 2021
Design System Sprint Board automation moved this from Needs review 🔍 to Done 🏁 Sep 27, 2021
@matteason matteason deleted the patch-1 branch September 28, 2021 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

Make layout names consistent
3 participants